Git in School, Good Code Reviews, Is PHP Back?

What you'll learn in this episode

• The importance of learning git in school
• What makes a good code review
• PHP may be back as some JavaScript frameworks mimic how things were done in PHP

How to support the show

Patreon

Prices subject to change and are listed in USD

• Support the show from as little as ~$1/month
• Get a shoutout at the end of the episode (while supplies last) for just ~$3/month
• Help support the HTML All The Things Podcast: Click Here

Scrimba Discount!

We receive a monetary kickback when you use our link

• Learn to code using Scrimba with their interactive follow along code editor
• Join their exclusive discord communities and network to find your first job!
• Use this URL to get 10% off on all their paid plans: https://tinyurl.com/ScrimbaHATT

Topics

Should Git be taught in Schools?

• What needs to be taught
  - Simple one day to practice
  -- Create repo
  -- Attach local dev environment
  -- First commit
  -- Create branch
  -- Merge branch
  -- Create/merge PR
• Git should be used from that day forward on all projects/assignments to make it a habit and second nature
• It’s not hard and you don’t need to dive too deep

What makes a good code review?

• Not full of nitpicks
  - These should be solved by linting/prettier configs
• Clear and concise
• Explanations as to why you’re requesting a change
  - Ex. change map to forEach, both can do similar things but one can be better than the other, why are you requesting one be used over another?
• PRs should be as small as possible, the larger the number of changes the less l likely your code will be reviewed well
• Run the code you are reviewing
• Perform reviews from your IDE to catch typescript errors easily 

Why is everything copying PHP?

• With the release of react server components it seems a lot of modern JavaScript framework paradigms and shifting towards a server-first approach
• The mixing of client and server code 
• State in URL
• This is reminiscent of how PHP works
• PHP had a lot of things right, 
  - server side rendering
  - Query params
• Reality is React just saw the benefit of being server side and inherently is doing what server side languages do
• It did not copy PHP it just is using a similar methodology 
• The main benefit of still using something like React and have it work both on the backend and frontend, making it much easier for one team to maintain a project

Links

• Code Reviews HTML All The Things podcast episode (Link)
• Unwritten rules of code reviews (Reddit)